Re: [PATCH 2/2] git-svn: support fetch with autocrlf on

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Feb 13, 2010, 23:59 UTC
Message-ID: <alpine.DEB.1.00.1002140055550.20986@pacific.mpi-cbg.de>
In-Reply-To: <40aa078e1002130616u478397c0xf757d5424630e6cf@mail.gmail.com>

Hi,

On Sat, 13 Feb 2010, Erik Faye-Lund wrote:

Show 5 quoted lines

> I don't think it affects svn dcommit in any way, except from the 
> implicit svn rebase that svn dcommit performs. d3c9634e sets 
> core.autocrlf to "false" on init, but re-enabling it hasn't shown any 
> problems in my end. I'm using git-svn with these patches and 
> core.autocrlf enabled every day at my day-job.

To elicit a warm and fuzzy feeling about your patch, you will have to analyze the code paaths of dcommit, and how crlf affects them. Then you will have to describe why dcommit does not have a problem with crlf with your patches anymore.

Remember, the idea of a commit message is to optimize the overall time balance, i.e. avoid the many to perform what the one can do for them. And since you have to do that analysis for yourself anyway, it makes sense to write up the result in the commit message.

Thanks, Dscho