Re: [PATCH 1/2] hash-object: support --stdin-paths with --no-filters
- From
Dmitry Potapov <dpotapov@gmail.com>
- Date
- Feb 12, 2010, 18:37 UTC
- Message-ID
- <37fcd2781002121037n4c98890eq5d635fc3bad5928a@mail.gmail.com>
- In-Reply-To
- <1265997155-3592-1-git-send-email-kusmabite@gmail.com>
Hi Erik,
I don't remember why I made --no-filters incompatible with --stdin-paths when I added it. So your patch makes perfect sense to me. However, I think you should correct synopsis in Documentation/git-hash-object.txt, so it will be clear that these two options can be used together now. Also, it would be nice if you add a test case to make sure that it works as expected and will not broken in the future..
Thanks, Dmitry