Re: [PATCH] Add the --submodule-summary option to the diff option family

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Oct 6, 2009, 11:45 UTC
Message-ID: <alpine.DEB.1.00.0910061344070.4686@intel-tinevez-2-302>
In-Reply-To: <7vocok21pw.fsf@alter.siamese.dyndns.org>

Hi,

On Tue, 6 Oct 2009, Junio C Hamano wrote:

Show 15 quoted lines

> Jens Lehmann <Jens.Lehmann@web.de> writes:
> 
> >> But I really, really, really want to avoid a fork() in the common case.  I 
> >> do have some users on Windows, and I do have a few submodules in that 
> >> project.  Having too many fork() calls there would just give Git a bad 
> >> reputation.  And it has enough of that, it does not need more.
> >
> > Me too thinks performance matters here. We do have a repo at my dayjob
> > with more than a handful of submodules and its main target platform is
> > windows ... so having that perform nicely is a win for us.
> 
> Numbers?
> 
> I'd prefer to avoid kludges that favors unsubstantiated performance
> argument over correctness.

Well, having worked with msysGit for such a long time, I just _know_ that a subprocess costs a substantial amount of time.

But as you don't trust my words, maybe Jens could be so kind as to perform some benchmarks? I am short on Git time budget, but I will make a commit on my submodule-summary branch that allows to start a subprocess always.

Ciao, Dscho