git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 02/11] Fix declare variable at mid of function

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Aug 17, 2009, 19:36 UTC
Message-ID
<alpine.DEB.1.00.0908172134150.8306@pacific.mpi-cbg.de>
In-Reply-To
<3f4fd2640908170934w4c48ada1o66745f845ecb7d49@mail.gmail.com>
Hi,
On Mon, 17 Aug 2009, Reece Dunn wrote:
Show 26 quoted lines
> 2009/8/17 Johannes Schindelin <Johannes.Schindelin@gmx.de>:
>
> > On Tue, 18 Aug 2009, Frank Li wrote:
> >
> >> Some compiler such as MSVC can't support declear variable at mid of 
> >> funtion at c file.
> >
> > Please wrap your commit messages after 76 characters.
> >
> >>
> >> Signed-off-by: Frank Li <lznuaa@gmail.com>
> >> ---
> >
> > How about this instead?
> >
> >        Avoid declaration after instruction
> >
> >        Microsoft Visual C++ does not understand this C99 style.
> >
> > ?
> >
> > The patch itself is good.
> 
> Shouldn't GCC be changed to use -std=c89 as well to pick up errors for 
> compilers that don't support c99 (like the Microsoft Visual C++ C 
> compiler)?

Hmm. I played with the thought of adding -Werror -Wno-pointer-to-int-cast -Wold-style-definition -Wdeclaration-after-statement like Junio described in one of his mails for MinGW (as we _know_ what compiler we have there).

Dunno.

Ciao, Dscho

Previous: Reece DunnNext: Marius Storm-Olsen
Message 13 of 26 in “Fix build failure at VC because function declare use old style at regex.c”
  1. 01/11 Fix build failure at VC because function declare use old style at regex.cFrank Li, Aug 17, 2009
  2. 02/11 Fix declare variable at mid of functionFrank Li, Aug 17, 2009
  3. 03/11 Define SNPRINTF_SIZE_CORR 1 when use MSVC build gitFrank Li, Aug 17, 2009
  4. 04/11 Add _MSC_VER predefine macro to make same behaviors with __MINGW32__ Enable MSVC build. MSVC have the save behaviors with msysgit.Frank Li, Aug 17, 2009
  5. Johannes SchindelinAug 17, 2009
  6. Frank LiAug 18, 2009
  7. tom fogalAug 18, 2009
  8. Johannes SchindelinAug 17, 2009
  9. Frank LiAug 18, 2009
  10. Johannes SchindelinAug 18, 2009
  11. Johannes SchindelinAug 17, 2009
  12. Reece DunnAug 17, 2009
  13. Johannes SchindelinAug 17, 2009
  14. Marius Storm-OlsenAug 18, 2009
  15. Johannes SchindelinAug 18, 2009
  16. Frank LiAug 18, 2009
  17. Matthieu MoyAug 18, 2009
  18. Johannes SchindelinAug 19, 2009
  19. Johannes SixtAug 19, 2009
  20. Johannes SchindelinAug 19, 2009
  21. Johannes SixtAug 19, 2009
  22. Junio C HamanoAug 17, 2009
  23. Johannes SchindelinAug 17, 2009
  24. Junio C HamanoAug 17, 2009
  25. Johannes SchindelinAug 17, 2009
  26. Frank LiAug 18, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.