From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Mon, 17 Aug 2009 19:36:08 GMT
Subject: Re: [PATCH 02/11] Fix declare variable at mid of function
Message-ID: <alpine.DEB.1.00.0908172134150.8306@pacific.mpi-cbg.de>
In-Reply-To: <3f4fd2640908170934w4c48ada1o66745f845ecb7d49@mail.gmail.com>

Hi,

On Mon, 17 Aug 2009, Reece Dunn wrote:

> 2009/8/17 Johannes Schindelin <Johannes.Schindelin@gmx.de>:
>
> > On Tue, 18 Aug 2009, Frank Li wrote:
> >
> >> Some compiler such as MSVC can't support declear variable at mid of 
> >> funtion at c file.
> >
> > Please wrap your commit messages after 76 characters.
> >
> >>
> >> Signed-off-by: Frank Li <lznuaa@gmail.com>
> >> ---
> >
> > How about this instead?
> >
> >        Avoid declaration after instruction
> >
> >        Microsoft Visual C++ does not understand this C99 style.
> >
> > ?
> >
> > The patch itself is good.
> 
> Shouldn't GCC be changed to use -std=c89 as well to pick up errors for 
> compilers that don't support c99 (like the Microsoft Visual C++ C 
> compiler)?

Hmm.  I played with the thought of adding -Werror -Wno-pointer-to-int-cast 
-Wold-style-definition -Wdeclaration-after-statement like Junio described 
in one of his mails for MinGW (as we _know_ what compiler we have there).

Dunno.

Ciao,
Dscho