Re: [msysGit] quick question about __stdcall at run-command.c mingw.c

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Aug 17, 2009, 09:12 UTC
Message-ID: <alpine.DEB.1.00.0908171109091.4991@intel-tinevez-2-302>
In-Reply-To: <4A891840.4050403@viscovery.net>

Hi,

On Mon, 17 Aug 2009, Johannes Sixt wrote:

Show 25 quoted lines

> Johannes Schindelin schrieb:
> > On Mon, 17 Aug 2009, Johannes Sixt wrote:
> >> Pat Thoyts schrieb:
> >>> 2009/8/17 Frank Li <lznuaa@gmail.com>:
> >>>> I am tring to clear VC build patch.
> >>>>
> >>>> I found __stdcall position break MSVC build.
> >>>>
> >>>> static __stdcall unsigned run_thread(void *data)
> >>>>
> >>>> MSVC require __stdcall should be between return type and function 
> >>>> name. like static unsigned __stdcall run_thread(void *data)
> >>>>
> >>>> I think msys gcc should support MSVC format.
> > 
> > I think that it does.
> > 
> > But it is _your_ duty to check.
> 
> Cool down. Asking for "please could you check whether this works" *if* 
> you don't have the infrastructure to test it yourself is certainly 
> dutyful enough.
> 
> Do you have an Irix, Solaris, HP box on your desk next to your Linux, so 
> that you don't have to ask others to test your patches?

This is Windows.  Frank has Windows.

Downloading msysGit does not incur any cost. Actually running the whole thing from the net installer just takes a little time and a two-digit megabyte download.

I put a lot of work into making this procedure as painless to use (for other people, it caused me a lot of pain). So Frank might just as well not let my effort go to hell.

Of course, Frank could ask one of the few msysGit contributors to try to compile something he prepared, wait for the results and possibly fix things for another round. This appears as a rather poor use of everybody's time, methinks.

Ciao, Dscho