Re: [msysGit] quick question about __stdcall at run-command.c mingw.c

From: Johannes Sixt <j.sixt@viscovery.net>
Date: Aug 17, 2009, 08:43 UTC
Message-ID: <4A891840.4050403@viscovery.net>
In-Reply-To: <alpine.DEB.1.00.0908171018490.4991@intel-tinevez-2-302>

Johannes Schindelin schrieb:

Show 17 quoted lines

> On Mon, 17 Aug 2009, Johannes Sixt wrote:
>> Pat Thoyts schrieb:
>>> 2009/8/17 Frank Li <lznuaa@gmail.com>:
>>>> I am tring to clear VC build patch.
>>>>
>>>> I found __stdcall position break MSVC build.
>>>>
>>>> static __stdcall unsigned run_thread(void *data)
>>>>
>>>> MSVC require __stdcall should be between return type and function 
>>>> name. like static unsigned __stdcall run_thread(void *data)
>>>>
>>>> I think msys gcc should support MSVC format.
> 
> I think that it does.
> 
> But it is _your_ duty to check.

Cool down. Asking for "please could you check whether this works" *if* you don't have the infrastructure to test it yourself is certainly dutyful enough.

Do you have an Irix, Solaris, HP box on your desk next to your Linux, so that you don't have to ask others to test your patches?

-- Hannes