Re: [PATCH 5/8] Add a config option for remotes to specify a foreign vcs
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Aug 11, 2009, 16:20 UTC
- Message-ID
- <alpine.DEB.1.00.0908111817490.4638@intel-tinevez-2-302>
- In-Reply-To
- <36ca99e90908110831g2ad52a5ar4a755723a6682f77@mail.gmail.com>
Hi,
On Tue, 11 Aug 2009, Bert Wesarg wrote:
Show 31 quoted lines
> On Mon, Aug 10, 2009 at 03:15, Junio C Hamano<gitster@pobox.com> wrote: > > Daniel Barkalow <barkalow@iabervon.org> writes: > > > >> If this is set, the url is not required, and the transport always uses > >> a helper named "git-remote-<value>". > >> > >> It is a separate configuration option in order to allow a sensible > >> configuration for foreign systems which either have no meaningful urls > >> for repositories or which require urls that do not specify the system > >> used by the repository at that location. However, this only affects > >> how the name of the helper is determined, not anything about the > >> interaction with the helper, and the contruction is such that, if the > >> foreign scm does happen to use a co-named url method, a url with that > >> method may be used directly. > > > > Personally, I do not like this. > > > > Why isn't it enough to define the canonical remote name git takes as > > "<name of the helper>:<whatever string the helper understands>"? > > May I ask what will happen to these supported URL notations: > > > o [user@]host.xz:/path/to/repo.git/ > > o [user@]host.xz:~user/path/to/repo.git/ > > o [user@]host.xz:path/to/repo.git > > this will bite you, if you have an ssh host alias named "<your > favorite helper name>".
That is a valid concern. I'd suggest to disallow @ and . in the protocol name (maybe even everything non-alnum). For shortcuts that really read like "svn", I think it is not too much asked for to require adjusting the URL (by prefixing ssh:// and adjusting the path).
If there is really anybody who uses Git via ssh to access a server called "svn", we could just as well have a little fun with them, don't you agree?
Ciao, Dscho