Re: [PATCH] git fast-export: add --no-data option

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Jul 25, 2009, 17:44 UTC
Message-ID: <alpine.DEB.1.00.0907251942390.8306@pacific.mpi-cbg.de>
In-Reply-To: <7vfxcku13i.fsf@alter.siamese.dyndns.org>

Hi,

On Sat, 25 Jul 2009, Junio C Hamano wrote:

Show 12 quoted lines

> Geoffrey Irving <irving@naml.us> writes:
> 
> > @@ -504,6 +508,8 @@ int cmd_fast_export(int argc, const char **argv,
> > const char *prefix)
> >  			     "Import marks from this file"),
> >  		OPT_BOOLEAN(0, "fake-missing-tagger", &fake_missing_tagger,
> >  			     "Fake a tagger when tags lack one"),
> > +		OPT_BOOLEAN(0, "no-data", &no_data,
> > +			     "Skip output of blob data"),
> 
> Shouldn't this be --[no-]data option that defaults to true?  Otherwise you
> would accept --no-no-data that looks silly.

Maybe

		OPT_NEGBIT(0, "data", &no_data,
			     "Skip output of blob data", 1),

Hmm?

Ciao,
Dscho