Re: [PATCH] git fast-export: add --no-data option

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 25, 2009, 17:25 UTC
Message-ID: <7vfxcku13i.fsf@alter.siamese.dyndns.org>
In-Reply-To: <7f9d599f0907250645s6e6f9b81w3cf20f07eff088eb@mail.gmail.com>

Geoffrey Irving <irving@naml.us> writes:

Show 7 quoted lines

> @@ -504,6 +508,8 @@ int cmd_fast_export(int argc, const char **argv,
> const char *prefix)
>  			     "Import marks from this file"),
>  		OPT_BOOLEAN(0, "fake-missing-tagger", &fake_missing_tagger,
>  			     "Fake a tagger when tags lack one"),
> +		OPT_BOOLEAN(0, "no-data", &no_data,
> +			     "Skip output of blob data"),

Shouldn't this be --[no-]data option that defaults to true? Otherwise you would accept --no-no-data that looks silly.

Show 5 quoted lines

>  		OPT_END()
>  	};
>
> -- 
> 1.6.3.1