git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/2] Fix git stash apply

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Jul 21, 2009, 20:56 UTC
Message-ID
<alpine.DEB.1.00.0907212253440.3155@pacific.mpi-cbg.de>
In-Reply-To
<1248206777-6984-1-git-send-email-mkoegler@auto.tuwien.ac.at>
Hi,
On Tue, 21 Jul 2009, Martin Koegler wrote:
> Signed-off-by: Martin Koegler <mkoegler@auto.tuwien.ac.at>

As "git stash" is run through the Git wrapper, which appends the libexec path to PATH, this is no "fix".

Apart from that, it is a nice patch, though, except maybe your leaving only white space between the commit subject and the sign-off: you could have _said_ that this is converting a dashed command to a non-dashed one, instead of sending everybody who is interested enough on a hunt where exactly those two lines differ (was not easy to spot, let me tell you this).

Hth, Dscho

Previous: Martin KoeglerNext: Junio C Hamano
Message 7 of 8 in “Fix git stash apply”
  1. 1/2 Fix git stash applyMartin Koegler, Jul 21, 2009
  2. 2/2 Replace remaining git-* calls in git stashMartin Koegler, Jul 21, 2009
  3. Johannes SchindelinJul 21, 2009
  4. Nanako ShiraishiJul 22, 2009
  5. Junio C HamanoJul 22, 2009
  6. Martin KoeglerJul 23, 2009
  7. Johannes SchindelinJul 21, 2009
  8. Junio C HamanoJul 21, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.