Re: [PATCH 1/2] Fix git stash apply

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 21, 2009, 20:57 UTC
Message-ID: <7v1vo9ah5v.fsf@alter.siamese.dyndns.org>
In-Reply-To: <alpine.DEB.1.00.0907212253440.3155@pacific.mpi-cbg.de>

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

Show 13 quoted lines

> On Tue, 21 Jul 2009, Martin Koegler wrote:
>
>> Signed-off-by: Martin Koegler <mkoegler@auto.tuwien.ac.at>
>
> As "git stash" is run through the Git wrapper, which appends the libexec 
> path to PATH, this is no "fix".
>
> Apart from that, it is a nice patch, though, except maybe your leaving 
> only white space between the commit subject and the sign-off: you could 
> have _said_ that this is converting a dashed command to a non-dashed one, 
> instead of sending everybody who is interested enough on a hunt where 
> exactly those two lines differ (was not easy to spot, let me tell you 
> this).

Thanks for a review. I think the two patches can be squashed into one and the subject from the second one reflects what is being done more fairly. It is modernizing the style of the codebase.