Re: [PATCH] Cast things properly to handle >2G files.
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Jun 15, 2009, 08:45 UTC
- Message-ID
- <alpine.DEB.1.00.0906151043180.4245@intel-tinevez-2-302>
- In-Reply-To
- <7vmy8ap2cq.fsf@alter.siamese.dyndns.org>
Hi,
On Sun, 14 Jun 2009, Junio C Hamano wrote:
Show 8 quoted lines
> "Alfred M. Szmidt" <ams@gnu.org> writes: > > > Oh, and maybe add a test like t/t5705-clone-2gb.sh? > > > > Thank you, that is a very good idea. > > Nah, one blob that is over 2gb, deltified against something else? > That's a bit too much for a test script.
Why not? It's not a difficult thing to come up with such a test. And just like t5705, it can be hidden behind an "EXPENSIVE_TEST=YesPlease" environment variable. Maybe I should have spelt that out loud instead of relying on interested parties to know t5705.
And just like t5705 it should help people to verify that the patch solves the problems indeed.
Ciao, Dscho