Re: [PATCH] Cast things properly to handle >2G files.
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Jun 14, 2009, 20:17 UTC
- Message-ID
- <alpine.DEB.1.00.0906142215560.26154@pacific.mpi-cbg.de>
- In-Reply-To
- <E1MFvux-0001ix-I7@fencepost.gnu.org>
Hi,
Disclaimer: if you are offended by constructive criticism, or likely to answer with insults to the comments I offer, please stop reading this mail now (and please do not answer my mail, either). :-)
Still with me? Good. Nice to meet you.
Just for the record: responding to a patch is my strongest way of saying that I appreciate your work.
On Sun, 14 Jun 2009, Alfred M. Szmidt wrote:
Show 6 quoted lines
> This small patch fixes things so that repack, fsck, and other things > work on >2GiB files. There are still some other problems (cloning > over ssh being one), but this makes it atleast possible to handle such > files. > > (not subscribed, please CC)
This is almost perfect, but please add a Signed-off-by: line.
Oh, and maybe add a test like t/t5705-clone-2gb.sh?
Ciao, Dscho