Re: [PATCH] git config: error when editing a repo config and not being in one

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Apr 30, 2009, 09:21 UTC
Message-ID: <alpine.DEB.1.00.0904301117040.6621@intel-tinevez-2-302>
In-Reply-To: <94a0d4530904300211j57903a3ei782b4e3e2f967c8a@mail.gmail.com>

Hi,

On Thu, 30 Apr 2009, Felipe Contreras wrote:

Show 18 quoted lines

> On Thu, Apr 30, 2009 at 11:37 AM, Johannes Schindelin
> <Johannes.Schindelin@gmx.de> wrote:
>
> > On Thu, 30 Apr 2009, Felipe Contreras wrote:
> >
> >> Let's throw an error on this specific case. If the user specifies the 
> >> config file, he must know what he is doing.
> >>
> >> Teemu Likonen pointed this out.
> >>
> >> Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
> >
> > I would have Acked it, but Junio already applied it ;-)
> 
> :)
> 
> Just for the record, where is people supposed to learn about 'nongit'? 
> Apparently it's not mentioned in the documentation.

It's not about 'nongit'. It is about setting up the git directory "gently", i.e you can ask for a setup _if possible_ using setup_git_directory_gently(), which will not fail if we're not in any repository.

To require a repository, call setup_git_directory(). This will die() if there is no repository.

As we already ask via _gently() in cmd_config(), it appeared natural to me to reuse that information rather than redoing the discovery.

Ciao, Dscho