[PATCH] git config: error when editing a repo config and not being in one

From: Felipe Contreras <felipe.contreras@gmail.com>
Date: Apr 29, 2009, 22:25 UTC
Message-ID: <1241043939-29013-1-git-send-email-felipe.contreras@gmail.com>

Let's throw an error on this specific case. If the user specifies the config file, he must know what he is doing.

Teemu Likonen pointed this out.

Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
---
 builtin-config.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/builtin-config.c b/builtin-config.c
index d8da72c..6e936e1 100644
--- a/builtin-config.c
+++ b/builtin-config.c
@@ -390,6 +390,8 @@ int cmd_config(int argc, const char **argv, const char *unused_prefix)
 	}
 	else if (actions == ACTION_EDIT) {
 		check_argc(argc, 0, 0);
+		if (!config_exclusive_filename && !is_inside_git_dir())
+			die("not in a git directory");
 		git_config(git_default_config, NULL);
 		launch_editor(config_exclusive_filename ?
 			      config_exclusive_filename : git_path("config"),

-- 
1.6.3.rc3.12.gb7937.dirty