Re: [PATCH] Removed redundant static functions such as update_tracking_ref() and verify_remote_names() from builtin-send-pack.c, and made the ones in transport.c not be static so they can be used instead.
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Apr 25, 2009, 00:07 UTC
- Message-ID
- <alpine.DEB.1.00.0904250206250.10279@pacific.mpi-cbg.de>
- In-Reply-To
- <99B4BF12-01B9-4A68-B2E0-EF5DF2595FF0@petdance.com>
Hi,
On Fri, 24 Apr 2009, Andy Lester wrote:
Show 7 quoted lines
> On Apr 24, 2009, at 4:04 PM, Jeff King wrote: > > >in git itself we usually use the imperative mood in commit mesages. > > This was what I was looking for. I think what I'll do is fold your > message into Documentation/SubmittingPatches and submit that as a patch > first.
I dunno. The most important part of CodingGuidelines is this:
As for more concrete guidelines, just imitate the existing code (this is a good guideline, no matter which project you are contributing to).
(And of course, this holds for the style of commit messages, too.)
Ciao, Dscho