git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Removed redundant static functions such as update_tracking_ref() and verify_remote_names() from builtin-send-pack.c, and made the ones in transport.c not be static so they can be used instead.

From
Jeff King <peff@peff.net>
Date
Apr 24, 2009, 21:23 UTC
Message-ID
<20090424212313.GA14435@coredump.intra.peff.net>
In-Reply-To
<99B4BF12-01B9-4A68-B2E0-EF5DF2595FF0@petdance.com>
On Fri, Apr 24, 2009 at 04:13:14PM -0500, Andy Lester wrote:
> This was what I was looking for.  I think what I'll do is fold your  
> message into Documentation/SubmittingPatches and submit that as a patch 
> first.
That probably makes sense.

I keep thinking about writing a separate "how to write a good commit message" document that would be more universal than just "here's how you submit a patch to git". And some of what I wrote to you could probably go in such a document. But I don't know if it makes sense to start a new document just with what I said there; it might be a bit sparse (OTOH, maybe people would then be encouraged to add their tips to it).

-Peff
Previous: Andy LesterNext: Junio C Hamano
Message 4 of 10 in “Removed redundant static functions such as update_tracking_ref() and verify_remote_names() from builtin-send-pack.c, and made the ones in transport.c not be static so they can be used instead.”
  1. Removed redundant static functions such as update_tracking_ref() and verify_remote_names() from builtin-send-pack.c, and made the ones in transport.c not be static so they can be used instead.andy@petdance.com, Apr 24, 2009
  2. Jeff KingApr 24, 2009
  3. Andy LesterApr 24, 2009
  4. Jeff KingApr 24, 2009
  5. Junio C HamanoApr 24, 2009
  6. Johannes SchindelinApr 25, 2009
  7. Andy LesterApr 25, 2009
  8. Johannes SchindelinApr 25, 2009
  9. Sam VilainApr 27, 2009
  10. Jeff KingApr 29, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.