git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [RFC/PATCH v2] graph API: Use horizontal lines for more compact graphs

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Apr 21, 2009, 13:17 UTC
Message-ID
<alpine.DEB.1.00.0904211517201.6559@intel-tinevez-2-302>
In-Reply-To
<20090421124701.GA25982@linux.vnet>
Hi,
> Everything else look good?
No objection from my side.
Show 6 quoted lines
> Actually now that I look at it, it might be a good idea to put an assert
> statement in that for loop like `assert(graph->new_mapping[j] < 0)' to
> make sure we don't clobber any existing lines.  But that seems like
> overkill since we're already assured to be the first collapsing edge at
> that point, which would imply that all previous odd indeces are empty.
> WDYT?
Yep, sounds like overkill to me, too.

Thanks! Dscho

Previous: Allan CaffeeNext: Teemu Likonen
Message 6 of 17 in “graph API: Use horizontal lines for more compact graphs”
  1. graph API: Use horizontal lines for more compact graphsAllan Caffee, Apr 21, 2009
  2. Johannes SchindelinApr 21, 2009
  3. Allan CaffeeApr 21, 2009
  4. Johannes SchindelinApr 21, 2009
  5. graph API: Use horizontal lines for more compact graphsAllan Caffee, Apr 21, 2009
  6. Johannes SchindelinApr 21, 2009
  7. Bug in colored "log --graph" implementationTeemu Likonen, Apr 21, 2009
  8. graph API: fix extra space during pre_commit_line stateAllan Caffee, Apr 21, 2009
  9. Teemu LikonenApr 22, 2009
  10. Allan CaffeeApr 22, 2009
  11. 2/3 graph API: fix extra space during pre_commit_line stateAllan Caffee, Apr 22, 2009
  12. 1/3 t4202-log: extend test coverage of graphingAllan Caffee, Apr 22, 2009
  13. 2/3 graph API: fix extra space during pre_commit_line stateAllan Caffee, Apr 22, 2009
  14. 3/3 graph API: fix a bug in the rendering of octopus mergesAllan Caffee, Apr 22, 2009
  15. Allan CaffeeApr 22, 2009
  16. graph API: Use horizontal lines for more compact graphsAllan Caffee, Apr 27, 2009
  17. Junio C HamanoApr 27, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.