From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Tue, 21 Apr 2009 13:17:59 GMT
Subject: Re: [RFC/PATCH v2] graph API: Use horizontal lines for more compact graphs
Message-ID: <alpine.DEB.1.00.0904211517201.6559@intel-tinevez-2-302>
In-Reply-To: <20090421124701.GA25982@linux.vnet>

Hi,

> Everything else look good?

No objection from my side.

> Actually now that I look at it, it might be a good idea to put an assert
> statement in that for loop like `assert(graph->new_mapping[j] < 0)' to
> make sure we don't clobber any existing lines.  But that seems like
> overkill since we're already assured to be the first collapsing edge at
> that point, which would imply that all previous odd indeces are empty.
> WDYT?

Yep, sounds like overkill to me, too.

Thanks!
Dscho