git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH (GIT-GUI BUG)] git-gui: use of undeclared variable in handle_empty_diff

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Apr 5, 2009, 21:35 UTC
Message-ID
<alpine.DEB.1.00.0904052334470.10279@pacific.mpi-cbg.de>
In-Reply-To
<0337ff5648e5e0dc583e255a44573dbf@mb8-2.1blu.de>
Hi,
On Sun, 5 Apr 2009, Joerg Bornemann wrote:
Show 6 quoted lines
> Commit 584fa9cc ("git-gui: Avoid an infinite rescan loop in 
> handle_empty_diff.") introduced the global variable diff_empty_count, 
> which is used in diff.tcl. But this variable isn't declared anywhere 
> which results in an ugly error message box instead of the intended 
> informative message. This patch fixes this and removes the unnecessary 
> second initialization of current_diff_path.
Under which circumstances does this bug trigger?  I never saw it happen.

Ciao, Dscho

Previous: Sverre Rabbelier
Message 3 of 3 in “git-gui: use of undeclared variable in handle_empty_diff”
  1. git-gui: use of undeclared variable in handle_empty_diffJoerg Bornemann, Apr 5, 2009
  2. Sverre RabbelierApr 5, 2009
  3. Johannes SchindelinApr 5, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.