From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Sun, 05 Apr 2009 21:35:10 GMT
Subject: Re: [PATCH (GIT-GUI BUG)] git-gui: use of undeclared variable in handle_empty_diff
Message-ID: <alpine.DEB.1.00.0904052334470.10279@pacific.mpi-cbg.de>
In-Reply-To: <0337ff5648e5e0dc583e255a44573dbf@mb8-2.1blu.de>

Hi,

On Sun, 5 Apr 2009, Joerg Bornemann wrote:

> Commit 584fa9cc ("git-gui: Avoid an infinite rescan loop in 
> handle_empty_diff.") introduced the global variable diff_empty_count, 
> which is used in diff.tcl. But this variable isn't declared anywhere 
> which results in an ugly error message box instead of the intended 
> informative message. This patch fixes this and removes the unnecessary 
> second initialization of current_diff_path.

Under which circumstances does this bug trigger?  I never saw it happen.

Ciao,
Dscho