git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] builtin-clone.c: fix memory leak in cmd_clone()

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Apr 1, 2009, 15:56 UTC
Message-ID
<alpine.DEB.1.00.0904011754250.13502@intel-tinevez-2-302>
In-Reply-To
<20090401144056.GC2237@lilem.mirepesht>
Hi,
On Wed, 1 Apr 2009, Ali Gholami Rudi wrote:
> With this patch, cmd_clone() safely frees its xstrdup()-allocated
> memory.  Also junk_work_tree and junk_git_dir (used in remove_junk()
> which is called asynchronously) were changed to use static arrays rather
> than sharing the memory allocated in cmd_clone().

If you want to go down that route, you will have a long way to go: the assumption is pretty much in every cmd_() and main() function that singletons will be free()d automatically when the process ends.

Ciao, Dscho

Previous: Ali Gholami RudiNext: Ali Gholami Rudi
Message 2 of 5 in “builtin-clone.c: fix memory leak in cmd_clone()”
  1. builtin-clone.c: fix memory leak in cmd_clone()Ali Gholami Rudi, Apr 1, 2009
  2. Johannes SchindelinApr 1, 2009
  3. Ali Gholami RudiApr 1, 2009
  4. Junio C HamanoApr 1, 2009
  5. Ali Gholami RudiApr 1, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.