From: Johannes Schindelin Date: Wed, 01 Apr 2009 15:56:34 GMT Subject: Re: [PATCH] builtin-clone.c: fix memory leak in cmd_clone() Message-ID: In-Reply-To: <20090401144056.GC2237@lilem.mirepesht> Hi, On Wed, 1 Apr 2009, Ali Gholami Rudi wrote: > With this patch, cmd_clone() safely frees its xstrdup()-allocated > memory. Also junk_work_tree and junk_git_dir (used in remove_junk() > which is called asynchronously) were changed to use static arrays rather > than sharing the memory allocated in cmd_clone(). If you want to go down that route, you will have a long way to go: the assumption is pretty much in every cmd_() and main() function that singletons will be free()d automatically when the process ends. Ciao, Dscho