Re: [PATCH/RFC] recv_sideband: Band #2 always goes to stderr

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Mar 10, 2009, 11:39 UTC
Message-ID: <alpine.DEB.1.00.0903101236480.14295@intel-tinevez-2-302>
In-Reply-To: <49B64C3A.50909@viscovery.net>

Hi,

FWIW GitTorrent may be implemented as part of git-daemon, if Sam's ideas become reality. And then, sideband transport is _the_ means to do asyncrounous communication while pushing bytes.

On Tue, 10 Mar 2009, Johannes Sixt wrote:

Show 14 quoted lines

> Johannes Sixt schrieb:
> > All data producers and data consumers *in git* use band #2 to 
> > transport error messages and progress report. GitTorrent cannot not 
> > talk to upload-pack or upload-archive and expect to get arbitrary 
> > binary data over band #2.
> > 
> > For use-cases that you have in mind in GitTorrent, the *protocol* may 
> > be a good choice, but the current implementation is definitely a 
> > special case.
> 
> And it really is: Did you notice that stuff that recv_sideband sends over
> the channel named 'err' (before my patch) has "remote: " prepended on
> every line? That's certainly not an implementation that you want if you
> send binary data over that band!

Yes, that is unfortunate, but can be fixed easily.

However, I disagree to "fix" something that is working, even if it might be more complicated than currently necessary.

Ciao, Dscho