Re: [PATCH] winansi: support ESC [ K (erase in line)

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Mar 10, 2009, 11:31 UTC
Message-ID: <alpine.DEB.1.00.0903101231240.14295@intel-tinevez-2-302>
In-Reply-To: <49B61377.90103@viscovery.net>

Hi,

On Tue, 10 Mar 2009, Johannes Sixt wrote:

Show 17 quoted lines

> Johannes Schindelin schrieb:
> > 	This fixes the last bit of msysGit issue 124 for me:
> > 
> > 		http://code.google.com/p/msysgit/issues/detail?id=124
> > 
> > 	which annoyed me one time to many today.
> > 
> > 	I had an earlier version which was smaller, but pretty hacky, in 
> > 	that it checked if fprintf is #define'd in xwrite(), and had 
> > 	special handling for that case.
> > 
> > 	This patch is only slightly hacky, in that it assumes that you do 
> > 	not try to output something that ends in an incomplete ESC [
> > 	sequence.
> 
> Good that I read mail before I start hacking. I was about to do something
> about this in a moment. ;)

Heh...

> > To make use of it during a fetch, write() needs to be overridden, too.
> 
> No, that's not necessary with the patch that I'm about to send in a
> moment. To replace write() for ANSI emulation really goes too far.

See my response to your patch...

Ciao, Dscho