Re: [PATCH] Brown paper bag fix for MinGW 64-bit stat

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Mar 7, 2009, 21:02 UTC
Message-ID: <alpine.DEB.1.00.0903072159500.10279@pacific.mpi-cbg.de>
In-Reply-To: <7vzlfxnlx2.fsf@gitster.siamese.dyndns.org>

Hi,

On Sat, 7 Mar 2009, Junio C Hamano wrote:

Show 20 quoted lines

> Johannes Schindelin <johannes.schindelin@gmx.de> writes:
> 
> > When overriding the identifier "stat" so that "struct stat" will be
> > substituted with "struct _stati64" everywhere, I tried to fix the calls
> > to the _function_ stat(), too, but I forgot to change the earlier
> > attempt "stat64" to "_stati64" there.
> >
> > So, the stat() calls were overridden by calls to _stati64() instead.
> >
> > Unfortunately, there is a function _stati64() so that I missed that
> > calls to stat() were not actually overridden by calls to mingw_lstat(),
> > but t4200-rerere.sh showed the error.
> >
> > Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
> 
> Since this is a fix-up to a new on 'master', I've applied the patch
> myself, but how would we want to handle MinGW related patches in general?
> 
> My preference is to have somebody I can rely on receiving Acked forwards
> from (or pulling from).

My preference is to keep the tried and tested mingw.git maintainer... ;-)

Note: IMHO Windows support is really at most beta quality; I would prefer 
only those using it who can fix bugs themselves, or have the means to make 
others fix the bugs.

So technically, we do not need such a strict and rigid process as for git.git itself, which is blessed with hundreds of contributors, due to which is really is ready for the end-user.

Ciao, Dscho