git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Brown paper bag fix for MinGW 64-bit stat

From
Johannes Sixt <j6t@kdbg.org>
Date
Mar 7, 2009, 19:46 UTC
Message-ID
<200903072046.23965.j6t@kdbg.org>
In-Reply-To
<03fcab37c921f5728deded11c07bdf32a263b79b.1236436185u.git.johannes.schindelin@gmx.de>
On Samstag, 7. März 2009, Johannes Schindelin wrote:
Show 5 quoted lines
> 	Actually, it was quite funny that t4200 displayed the bug; I
> 	_guess_ it was due to a time zone issue, as the times were exactly
> 	one hour off (and the machine I tested on is at UTC+0100 right now).
>
> 	And due to that bug, "rerere gc" would not collect the garbage.

U-oh, you are right! I was 100% sure that I ran the test-suite suite with your earlier patch and it was all OK before I gave my ACK. But appearently I did something wrong because today I see the failure in t4200, too, and this fixes it, and it is the right thing to do.

> -#define stat64(x,y) mingw_lstat(x,y)
> +#define _stati64(x,y) mingw_lstat(x,y)
Acked-by: Johannes Sixt <j6t@kdbg.org>
-- Hannes
Previous: Johannes SchindelinNext: Junio C Hamano
Message 2 of 4 in “Brown paper bag fix for MinGW 64-bit stat”
  1. Brown paper bag fix for MinGW 64-bit statJohannes Schindelin, Mar 7, 2009
  2. Johannes SixtMar 7, 2009
  3. Junio C HamanoMar 7, 2009
  4. Johannes SchindelinMar 7, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.