git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [RFC PATCH 0/4] git log -g --pretty=format: learns about reflog

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Feb 26, 2009, 10:30 UTC
Message-ID
<alpine.DEB.1.00.0902261125230.6258@intel-tinevez-2-302>
In-Reply-To
<cover.1235622145.git.deskinm@umich.edu>
Hi,
On Wed, 25 Feb 2009, Deskin Miller wrote:
Show 5 quoted lines
> I strongly suspect that there's a cleaner way to do this, but don't 
> really know what that would be, so any comments regarding alternate 
> approaches would be very appreciated.  Also, I'm more than happy to 
> write testcases and documentation once there is some agreement about 
> what the preferred implementation is.
>From skimming your mail, I am not quite sure if I understand correctly

what you want to do. Is it that you want to be able to output the "Reflog:" and "Reflog message:" information that "git log -g" prints?

If so, I suggest expanding the signature of format_commit_message.

Even better: define a "struct format_commit_options" a pointer to which gets passed around, and which should make the code cleaner anyway.

You could then put a pointer to the reflog_info into that struct.

Ciao, Dscho

Previous: Deskin MillerNext: Jeff King
Message 6 of 7 in “git log -g --pretty=format: learns about reflog”
  1. 0/4 git log -g --pretty=format: learns about reflogDeskin Miller, Feb 26, 2009
  2. 1/4 Expose reflog_info struct in headerDeskin Miller, Feb 26, 2009
  3. 2/4 Add attach_reflog_infoDeskin Miller, Feb 26, 2009
  4. 3/4 Attach reflog to commit prior to pretty-printingDeskin Miller, Feb 26, 2009
  5. 4/4 Teach pretty-printer new reflog format codesDeskin Miller, Feb 26, 2009
  6. Johannes SchindelinFeb 26, 2009
  7. Jeff KingFeb 26, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.