From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Thu, 26 Feb 2009 10:30:01 GMT
Subject: Re: [RFC PATCH 0/4] git log -g --pretty=format: learns about reflog
Message-ID: <alpine.DEB.1.00.0902261125230.6258@intel-tinevez-2-302>
In-Reply-To: <cover.1235622145.git.deskinm@umich.edu>

Hi,

On Wed, 25 Feb 2009, Deskin Miller wrote:

> I strongly suspect that there's a cleaner way to do this, but don't 
> really know what that would be, so any comments regarding alternate 
> approaches would be very appreciated.  Also, I'm more than happy to 
> write testcases and documentation once there is some agreement about 
> what the preferred implementation is.

>From skimming your mail, I am not quite sure if I understand correctly 
what you want to do.  Is it that you want to be able to output the 
"Reflog:" and "Reflog message:" information that "git log -g" prints?

If so, I suggest expanding the signature of format_commit_message.

Even better: define a "struct format_commit_options" a pointer to 
which gets passed around, and which should make the code cleaner 
anyway.

You could then put a pointer to the reflog_info into that struct.

Ciao,
Dscho