Re: What's cooking in git.git (Jan 2009, #07; Wed, 28)

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Feb 12, 2009, 11:04 UTC
Message-ID: <alpine.DEB.1.00.0902121200420.10279@pacific.mpi-cbg.de>
In-Reply-To: <7v3aekqhpo.fsf@gitster.siamese.dyndns.org>

Hi,

On Wed, 11 Feb 2009, Junio C Hamano wrote:

Show 20 quoted lines

> Junio C Hamano <gitster@pobox.com> writes:
> 
> > Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> >
> >> How about installing
> >>
> >> 	[branch "master"]
> >> 		remote = origin
> >> 		merge = refs/heads/master
> >>
> >> by default?  It is a safe bet that this will be the case for 99% of all 
> >> users that want to clone an empty repository (especially if they are 
> >> putting their public repositories on something like repo.or.cz, where you 
> >> cannot change the default branch from "master" to something else).
> >
> > I think this is a reasonable thing to do.
> 
> So I've been sort of waiting for a trivial patch to materialize, and then
> almost forgot about it like everybody else did.  Before all of us forget,
> here is my attempt to do the above.

Thanks.

> We seem to have acquired a bad habit of discussing and agreeing on a 
> potential improvement and then not following through, forgetting it 
> altogether.

Yeah, I am pretty excited at my rebase -i -p branch at the moment, so I am prone to forget other things (push --track included).

> And no, a bug tracker is not the answer, even though it could be a 
> (small) part of the solution.

If you really want to know how much a bug tracker is not the solution, because it is a fire-and-forget (as in post, and never come back, even with a small little message that the fix actually worked) place for many bug reporters, just look at msysGit's bug tracker and weep.

Show 10 quoted lines

> diff --git a/builtin-clone.c b/builtin-clone.c
> index f73029e..431c136 100644
> --- a/builtin-clone.c
> +++ b/builtin-clone.c
> @@ -350,6 +350,18 @@ static struct ref *write_remote_refs(const struct ref *refs,
>  	return local_refs;
>  }
>  
> +static void install_branch_config(const char *origin, const char *local,
> +				  const char *remote)

I would have used a different order (local, origin, remote), but that's okay, I guess.

Ciao, Dscho