Re: [RFC PATCH] git-sh-setup: Use "cd" option, not /bin/pwd, for symlinked work tree

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Feb 8, 2009, 20:56 UTC
Message-ID: <alpine.DEB.1.00.0902082154450.10279@pacific.mpi-cbg.de>
In-Reply-To: <498F2049.9030608@oak.homeunix.org>

Hi,

On Sun, 8 Feb 2009, Marcel M. Cary wrote:

Show 12 quoted lines

> Johannes Schindelin wrote:
> > On Fri, 6 Feb 2009, Marcel M. Cary wrote:
> >> While the "-P" option may be slightly less commonly supported than
> >> /bin/pwd,
> >
> > Does this not suggest that your patch should at least fall back to
> > using /bin/pwd when it was detected that "cd -P" does not work?
> 
> Having the "cd -P" strategy fall back to /bin/pwd negates most of the
> value I saw in using the simpler strategy.
> 
> I haven't found cases where "cd -P" is more correct.

Actually, it was not clear for me how much you researched the portability of "cd -P".

As long as it is not proven that your patch keeps working setups working, I think you'll have to put in a bit more effort, research it, and then put the discussion into the commit message.

Ciao, Dscho