Re: [PATCH 7/8] Tests: let --valgrind imply --verbose and --tee

From

Johannes Schindelin <johannes.schindelin@gmx.de>

Date

Feb 6, 2009, 19:40 UTC

Message-ID

<alpine.DEB.1.00.0902062038420.7377@intel-tinevez-2-302>

In-Reply-To

<20090206190815.GB19494@coredump.intra.peff.net>

Hi,

On Fri, 6 Feb 2009, Jeff King wrote:

> On Wed, Feb 04, 2009 at 12:26:26AM +0100, Johannes Schindelin wrote:
> 
> > It does not make much sense to run the (expensive) valgrind tests and
> > not look at the output.
> > 
> > To prevent output from scrolling out of reach, the parameter --tee is
> > implied, too.
> 
> Might it not make sense to want to send the output to a file, but _not_
> show it on the terminal (e.g., running from a cron job)?

That is sh ... > file 2>&1

> But if I understand correctly, that is not actually possible with any 
> combination of "--verbose" and "--tee".

No, it is not, indeed.

> So perhaps it would make more sense to have, rather than "--tee", simply 
> "--verbose" to output to the terminal and "--save-output" (or similar) 
> to save the output. If both are requested, it is equivalent to what 
> "--tee" does now.

I do not see the point in that.

> On the other hand, I think "--verbose --tee >/dev/null" would probably 
> accomplish the same thing, so it probably isn't worth too much effort.