git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 7/8] Tests: let --valgrind imply --verbose and --tee

From
Jeff King <peff@peff.net>
Date
Feb 6, 2009, 19:08 UTC
Message-ID
<20090206190815.GB19494@coredump.intra.peff.net>
In-Reply-To
<alpine.DEB.1.00.0902040026250.9822@pacific.mpi-cbg.de>
On Wed, Feb 04, 2009 at 12:26:26AM +0100, Johannes Schindelin wrote:
Show 5 quoted lines
> It does not make much sense to run the (expensive) valgrind tests and
> not look at the output.
> 
> To prevent output from scrolling out of reach, the parameter --tee is
> implied, too.

Might it not make sense to want to send the output to a file, but _not_ show it on the terminal (e.g., running from a cron job)? But if I understand correctly, that is not actually possible with any combination of "--verbose" and "--tee".

So perhaps it would make more sense to have, rather than "--tee", simply "--verbose" to output to the terminal and "--save-output" (or similar) to save the output. If both are requested, it is equivalent to what "--tee" does now.

On the other hand, I think "--verbose --tee >/dev/null" would probably accomplish the same thing, so it probably isn't worth too much effort.

Other than that, this series looks pretty reasonable. I am a bit late to ack, but thank you for following through on it. It looks like it has caught some bugs already, which is always a good sign. :)

I have access to a decent quad-core box, so I'll try to periodically run the test suite with valgrind on it. Daily is probably too much, but maybe whenever we go into rc-freeze is a good time.

-Peff
Previous: Johannes SchindelinNext: Johannes Schindelin
Message 8 of 11 in “Add valgrind support in test scripts”
  1. 1/8 Add valgrind support in test scriptsJohannes Schindelin, Feb 3, 2009
  2. 2/8 valgrind: ignore ldso and more libz errorsJohannes Schindelin, Feb 3, 2009
  3. 3/8 Valgrind support: check for more than just programming errorsJohannes Schindelin, Feb 3, 2009
  4. 4/8 test-lib.sh: optionally output to test-results/$TEST.out, tooJohannes Schindelin, Feb 3, 2009
  5. 5/8 t/Makefile: provide a 'valgrind' targetJohannes Schindelin, Feb 3, 2009
  6. 6/8 Add a script to coalesce the valgrind outputsJohannes Schindelin, Feb 3, 2009
  7. 7/8 Tests: let --valgrind imply --verbose and --teeJohannes Schindelin, Feb 3, 2009
  8. Jeff KingFeb 6, 2009
  9. Johannes SchindelinFeb 6, 2009
  10. Jeff KingFeb 6, 2009
  11. 8/8 test-lib: avoid assuming that templates/ are in the GIT_EXEC_PATHJohannes Schindelin, Feb 3, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.