Re: [PATCH] filter-branch: do not consider diverging submodules a 'dirty worktree'

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Feb 4, 2009, 17:24 UTC
Message-ID: <alpine.DEB.1.00.0902041823330.22763@intel-tinevez-2-302>
In-Reply-To: <7vvdrqunog.fsf@gitster.siamese.dyndns.org>

Hi,

On Wed, 4 Feb 2009, Junio C Hamano wrote:

Show 13 quoted lines

> Johannes Schindelin <johannes.schindelin@gmx.de> writes:
> 
> > As filter-branch could not care less about submodules' actual 
> > contents, it does not make sense to check if the checked-out 
> > submodules are up-to-date before running filter-branch.  So do not do 
> > it.
> 
> Sorry, but I am confused.  Is that because even the tree-filter does not 
> use the actual work tree but works in the temporary area .git-rewrite, 
> and a diverged submodule cannot possibly matter (and index-filter works 
> solely on the index anyway)?
> 
> If so, why do we even check dirtiness of anything at all?

I guess it is because we could update the working directory with read-tree -u -m HEAD at the end. Actually, that is exactly what we do.

Submodules do not matter much here, as nothing will be overwritten, really, but a dirty working directory matters.

Ciao, Dscho