git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] filter-branch: do not consider diverging submodules a 'dirty worktree'

From
Junio C Hamano <gitster@pobox.com>
Date
Feb 4, 2009, 18:00 UTC
Message-ID
<7vvdrqt74k.fsf@gitster.siamese.dyndns.org>
In-Reply-To
<4989CF79.2070209@viscovery.net>
Johannes Sixt <j.sixt@viscovery.net> writes:
Show 6 quoted lines
> Because if the repository is non-bare, then filter-branch updates the
> work-tree at the end of the run; we don't want to overwrite uncommitted
> work in this case.
>
> This behavior is a relic from cg-admin-rewritehist, I think. I've never
> found it useful.

Ok, I think "read-tree -m -u HEAD" at the end sort of makes sense, if you filtered the branch you are currently sitting on. Does that mean we do not have to barf on dirtyness if we can tell if the filter-branch will not touch the current branch at all? Again, I am not suggesting it as an improvement, but I am trying to see if I am talking a total nonsense.

Is the reason why you haven't found it is useful is because you never filter the current branch?

Previous: Johannes SixtNext: Johannes Schindelin
Message 5 of 9 in “filter-branch: do not consider diverging submodules a 'dirty worktree'”
  1. filter-branch: do not consider diverging submodules a 'dirty worktree'Johannes Schindelin, Feb 4, 2009
  2. Junio C HamanoFeb 4, 2009
  3. Johannes SchindelinFeb 4, 2009
  4. Johannes SixtFeb 4, 2009
  5. Junio C HamanoFeb 4, 2009
  6. Johannes SchindelinFeb 4, 2009
  7. Junio C HamanoFeb 4, 2009
  8. Johannes SchindelinFeb 5, 2009
  9. Johannes SixtFeb 5, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.