Re: [PATCH] push: Learn to set up branch tracking with '--track'

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Jan 30, 2009, 17:05 UTC
Message-ID: <alpine.DEB.1.00.0901301804030.3586@pacific.mpi-cbg.de>
In-Reply-To: <20090130162258.GA7065@sigill.intra.peff.net>

Hi,

On Fri, 30 Jan 2009, Jeff King wrote:

Show 10 quoted lines

> I think the right thing to do is:
> 
>   1. factor out "generic" routines from send-pack, including status
>      output formatting and tracking ref updating
> 
>   2. refactor http-push to use those routines, bringing it in line with
>      send-pack
> 
>   3. add --track support in the same generic way, and hook it from both
>      transports

Now we're thinking along the same lines!

> I can try to work on this, but I'm not excited about major surgery to 
> http-push, which I don't have a working test setup for.

You don't have an apache installed?

> I can't bring myself to care about refactoring rsync, given the recent 
> deprecation discussion.

Don't do it, then.

Show 5 quoted lines

> If it is going to be added to push or transport, then the transport API 
> needs refactoring to actually pass out information on what happened 
> (specifically, how we expanded the refspecs into matching ref pairs). 
> And maybe that is a more sensible long-term solution, but it is going 
> involve a lot of changes, too.

I think that the --track should just be passed to the transport API, which should call the necessary git_config thing itself upon successful push.

Ciao, Dscho