git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] push: Learn to set up branch tracking with '--track'

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Jan 30, 2009, 15:58 UTC
Message-ID
<alpine.DEB.1.00.0901301656290.3586@pacific.mpi-cbg.de>
In-Reply-To
<20090130050925.GA18809@coredump.intra.peff.net>
Hi,
On Fri, 30 Jan 2009, Jeff King wrote:
Show 23 quoted lines
> On Fri, Jan 30, 2009 at 01:28:38AM +0100, Johannes Schindelin wrote:
> 
> > > Something like the patch below (which is obviously missing all of the 
> > > infrastructure for doing this optionally, but is meant to illustrate 
> > > what I'm talking about).
> > 
> > Except that you miss http:// and rsync:// protocols.  Those were the 
> > reasons I did not touch send-pack.
> 
> You didn't comment on the part of my email where I said exactly that,
> but that I think this is still the right path forward.
> 
> Pushing through those protocols is sorely in need of update (actually,
> I thought rsync was all but dead at this point). But http push is
> missing the update of tracking refs, the usual status output (it still
> has the "Maybe you are not up-to-date and need to pull first?" message
> that was removed from send-pack a year and a half ago), and who knows
> what other tweaks made to do_send_pack (which it appears to have been
> copy-and-pasted from in 2006) in the last few years.
> 
> So either we don't care about http-push being consistent with send-pack,
> and it is OK to have this feature in one but not the other. Or we do,
> and we really need to clean up the current divergence.

I do not see how your patch to send-pack makes that divergence any better, or for that matter, keeps it as bad as it is.

In other words, if you want to give the other protocols at least a _chance_ to catch up, you definitely need the support for push --track in builtin-push.c or at least in transport.c.

Ciao, Dscho

Previous: Jeff KingNext: Jeff King
Message 9 of 15 in “push: Learn to set up branch tracking with '--track'”
  1. push: Learn to set up branch tracking with '--track'Johannes Schindelin, Jan 29, 2009
  2. Sverre RabbelierJan 29, 2009
  3. Johannes SchindelinJan 29, 2009
  4. Johannes SchindelinJan 29, 2009
  5. Jeff KingJan 29, 2009
  6. Jeff KingJan 29, 2009
  7. Johannes SchindelinJan 30, 2009
  8. Jeff KingJan 30, 2009
  9. Johannes SchindelinJan 30, 2009
  10. Jeff KingJan 30, 2009
  11. Johannes SchindelinJan 30, 2009
  12. Jeff KingFeb 2, 2009
  13. Johannes SchindelinFeb 2, 2009
  14. Jeff KingFeb 6, 2009
  15. Johannes SchindelinFeb 6, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.