Re: [PATCH] Allow cloning an empty repository

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Jan 23, 2009, 20:05 UTC
Message-ID: <alpine.DEB.1.00.0901232100020.21467@intel-tinevez-2-302>
In-Reply-To: <20090123165549.GI21473@genesis.frugalware.org>

Hi,

On Fri, 23 Jan 2009, Miklos Vajna wrote:

Show 7 quoted lines

> On Fri, Jan 23, 2009 at 04:20:34AM +0100, Johannes Schindelin 
> <Johannes.Schindelin@gmx.de> wrote:
>
> > But then, scripts have no business cloning repositories (fetching, 
> > yes.  But cloning?)
> 
> I think portals like repo.or.cz may do it.

"git grep git.clone" in repo.git suggests that only clonecheck.sh uses it, which is not called anywhere.

But more generally, the same should apply to such scripts as to human users: HTTP _is_ 2nd class, and the fetch _could_ succeed later.

> Isn't setting errno (or similar variable) in the HTTP code an option? 
> Then we could see why the transport failed and make a difference between 
> "network error" and "no refs found".

I'd rather see the HTTP code path taken by transport.c _fail_ (i.e. die()) when there is some sort of connection error.

Ciao, Dscho