git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Allow cloning an empty repository

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Jan 23, 2009, 02:42 UTC
Message-ID
<alpine.DEB.1.00.0901230333060.3586@pacific.mpi-cbg.de>
In-Reply-To
<bd6139dc0901221746h258f548etf857ab37399133da@mail.gmail.com>
Hi,
On Fri, 23 Jan 2009, Sverre Rabbelier wrote:
Show 12 quoted lines
> On Fri, Jan 23, 2009 at 02:24, Junio C Hamano <gitster@pobox.com> wrote:
> > I think the basic idea is Ok, but is it a reliable check at this point to
> > see if (refs == NULL) to tell if the target repository is an empty one?
> 
> This is the question I asked Dscho, and he said/guessed that it was.
> 
> > I am mostly worried about a failure case (connected but couldn't get 
> > the refs, or perhaps connection failed to start).  If you get a NULL 
> > in such a case you may end up saying "oh you cloned a void" when you 
> > should say "nah, such a remote repository does not exist".
> 
> Yes, this was my concern as well.
>From what I can see in get_remote_heads(), the native protocols would 
die(), as would rsync().

HTTP transport, however, would not die() on connection errors, from my cursory look.

That might be skewed, though, as I am on top of Mike's patches (in the hopefully not so futile hope that Mike -- after letting me wait for over one year -- finishes his work.

HTTP being 2nd class citizen anyway (and we can always fix it after Mike's cleanups), I'd say this patch is ready to roll.

Ciao, Dscho

Previous: Sverre RabbelierNext: Sverre Rabbelier
Message 4 of 23 in “Allow cloning an empty repository”
  1. Allow cloning an empty repositorySverre Rabbelier, Jan 23, 2009
  2. Junio C HamanoJan 23, 2009
  3. Sverre RabbelierJan 23, 2009
  4. Johannes SchindelinJan 23, 2009
  5. Sverre RabbelierJan 23, 2009
  6. Johannes SchindelinJan 23, 2009
  7. Miklos VajnaJan 23, 2009
  8. Johannes SchindelinJan 23, 2009
  9. Jeff KingJan 23, 2009
  10. Sverre RabbelierJan 23, 2009
  11. Jeff KingJan 23, 2009
  12. Sverre RabbelierJan 23, 2009
  13. Johannes SchindelinJan 24, 2009
  14. Mike HommeyJan 23, 2009
  15. http fixes, was Re: [PATCH] Allow cloning an empty repositoryJohannes Schindelin, Jan 24, 2009
  16. Sverre RabbelierJan 24, 2009
  17. Miklos VajnaJan 23, 2009
  18. Johannes SchindelinJan 24, 2009
  19. Sverre RabbelierJan 24, 2009
  20. Miklos VajnaJan 25, 2009
  21. Sverre RabbelierJan 25, 2009
  22. Junio C HamanoJan 25, 2009
  23. Sverre RabbelierJan 25, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.