Re: [PATCH 1/3] sha1_file: add function to insert alternate object db

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Jan 18, 2009, 15:32 UTC
Message-ID: <alpine.DEB.1.00.0901181629590.3586@pacific.mpi-cbg.de>
In-Reply-To: <1232275999-14852-2-git-send-email-hjemli@gmail.com>

Hi,

On Sun, 18 Jan 2009, Lars Hjemli wrote:

Show 23 quoted lines

> diff --git a/cache.h b/cache.h
> index 8e1af26..daa2d4e 100644
> --- a/cache.h
> +++ b/cache.h
> @@ -724,6 +724,7 @@ extern struct alternate_object_database {
>  	char base[FLEX_ARRAY]; /* more */
>  } *alt_odb_list;
>  extern void prepare_alt_odb(void);
> +extern int add_alt_odb(const char *path);
>  extern void add_to_alternates_file(const char *reference);
>  typedef int alt_odb_fn(struct alternate_object_database *, void *);
>  extern void foreach_alt_odb(alt_odb_fn, void*);
> diff --git a/sha1_file.c b/sha1_file.c
> index f08493f..19f9725 100644
> --- a/sha1_file.c
> +++ b/sha1_file.c
> @@ -356,6 +356,11 @@ static void link_alt_odb_entries(const char *alt, const char *ep, int sep,
>  	}
>  }
>  
> +int add_alt_odb(const char *path)
> +{
> +	return link_alt_odb_entry(path, strlen(path), NULL, 0);

This function can return the error message "object directory %s does not exist; check .git/objects/info/alternates." Maybe you want to change that, even if the user you are introducing might not hit that code path.

Ciao, Dscho