Re: [PATCH 2/3] Teach read_tree_recursive() how to traverse into submodules
- From
- Lars Hjemli <hjemli@gmail.com>
- Date
- Jan 18, 2009, 19:50 UTC
- Message-ID
- <8c5c35580901181150t1827455elbe2be224a33f1b36@mail.gmail.com>
- In-Reply-To
- <7vfxjgxwv7.fsf@gitster.siamese.dyndns.org>
On Sun, Jan 18, 2009 at 20:00, Junio C Hamano <gitster@pobox.com> wrote:
Show 12 quoted lines
> Lars Hjemli <hjemli@gmail.com> writes: > >> I like the idea, but it will require thorough review of all >> read_tree_recursive() consumers. So now we've got three different >> approaches: >> * me: global setting >> * dscho: parameter to read_tree_recursive() >> * you: accept the return value from the callback function >> >> Junio, what would you prefer? > > As usual René has the best taste in designing things ;-)
Agreed. I've pushed an updated series using his approach to the lh/traverse-gitlinks branch in git://hjemli.net/pub/git/git (http://hjemli.net/git/git/log/?h=lh/traverse-gitlinks), but without a fix for Dscho's concern about the behaviour in tree.c::traverse_gitlink(). Hopefully I'll get to send a reworked series later tonight.
-- larsh