Re: [PATCH 3/3] http-push: update tests

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Jan 17, 2009, 05:23 UTC
Message-ID: <alpine.DEB.1.00.0901170621440.3586@pacific.mpi-cbg.de>
In-Reply-To: <be6fef0d0901161859qbea135bwe89e48caaa69a77c@mail.gmail.com>

Hi,

On Sat, 17 Jan 2009, Ray Chuan wrote:

> note: the test needs to chmod the test_repo.git folder so that
> apache/mod_dav can create .DAV folders in it for locking.

Is this supposed to explain ...

Show 15 quoted lines

> @@ -51,17 +51,16 @@ test_expect_success 'clone remote repository' '
>  	git clone $HTTPD_URL/test_repo.git test_repo_clone
>  '
> 
> -test_expect_failure 'push to remote repository' '
> +test_expect_success 'push to remote repository' '
>  	cd "$ROOT_PATH"/test_repo_clone &&
>  	: >path2 &&
>  	git add path2 &&
>  	test_tick &&
>  	git commit -m path2 &&
> -	git push &&
> -	[ -f "$HTTPD_DOCUMENT_ROOT_PATH/test_repo.git/refs/heads/master" ]
> +	git push origin master
>  '

... this removal? I do not think this is a good change, as it removes a test that is actually pretty important.

BTW I do not understand at all what you mean by "we need to chmod". Does the Apache instance not run with the current user's permissions?

Ciao, Dscho