Re: [PATCH 3/3] http-push: update tests

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 17, 2009, 18:54 UTC
Message-ID: <7vsknh7og5.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <be6fef0d0901170040r7e11806et87cc5dc3c6f13a2a@mail.gmail.com>

"Ray Chuan" <rctay89@gmail.com> writes:

Show 20 quoted lines

>>> -test_expect_failure 'push to remote repository' '
>>> +test_expect_success 'push to remote repository' '
>>>       cd "$ROOT_PATH"/test_repo_clone &&
>>>       : >path2 &&
>>>       git add path2 &&
>>>       test_tick &&
>>>       git commit -m path2 &&
>>> -     git push &&
>>> -     [ -f "$HTTPD_DOCUMENT_ROOT_PATH/test_repo.git/refs/heads/master" ]
>>> +     git push origin master
>>>  '
>>
>> ... this removal?  I do not think this is a good change, as it removes
>> a test that is actually pretty important.
>
> i'm sorry for the poor commit message, what i wanted to do was to
> change the tests to expect success rather than failure. no tests were
> removed; only their expected outcomes were modified. currently, the
> pushes fail, so the test 'fails as expected'; now the pushes succeed,
> so they shouldn't be expecting failed pushes (or anything else).

The original seems to want the push to succeed, and also it wants the file refs/heads/master to be present after the push (presumably because there should be that ref when the push succeeds). If you fixed "push" that used to fail to succeed, that is great, and s/failure/success/ is a good thing.

But you are removing something else without explanation. Why do you need to remove the part of the test that checks if refs/heads/master is present? Is it looking for a file in a wrong place?