git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [RESEND PATCH] fast-import: Cleanup mode setting.

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Jan 14, 2009, 02:28 UTC
Message-ID
<alpine.DEB.1.00.0901140326530.3586@pacific.mpi-cbg.de>
In-Reply-To
<20090114021751.GW10179@spearce.org>
Hi,
On Tue, 13 Jan 2009, Shawn O. Pearce wrote:
Show 13 quoted lines
> Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:
> > On Wed, 14 Jan 2009, Felipe Contreras wrote:
> > 
> > > "S_IFREG | mode" probably is only required for 0644 and 0755.
> > 
> > Why should we want to have that patch?  IOW what does it fix, and what 
> > might it break?
> 
> It cleans up the code to make it more readable.
> 
> It makes no sense to be doing S_IFREG | S_IFLINK, which happens when
> the input is for a symlink.  It doesn't break anything to do that |
> operation, but it also looks damn odd when reading the function.

Imagining myself reading the commit message 6 months from now, in all likeliness I will have wished that those two paragraphs were in there. Verbatim.

Ciao, Dscho

Previous: Shawn O. PearceNext: Shawn O. Pearce
Message 4 of 8 in “fast-import: Cleanup mode setting.”
  1. fast-import: Cleanup mode setting.Felipe Contreras, Jan 14, 2009
  2. Johannes SchindelinJan 14, 2009
  3. Shawn O. PearceJan 14, 2009
  4. Johannes SchindelinJan 14, 2009
  5. Shawn O. PearceJan 14, 2009
  6. Felipe ContrerasJan 14, 2009
  7. Shawn O. PearceJan 14, 2009
  8. Shawn O. PearceJan 14, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.