From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Wed, 14 Jan 2009 02:28:31 GMT
Subject: Re: [RESEND PATCH] fast-import: Cleanup mode setting.
Message-ID: <alpine.DEB.1.00.0901140326530.3586@pacific.mpi-cbg.de>
In-Reply-To: <20090114021751.GW10179@spearce.org>

Hi,

On Tue, 13 Jan 2009, Shawn O. Pearce wrote:

> Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:
> > On Wed, 14 Jan 2009, Felipe Contreras wrote:
> > 
> > > "S_IFREG | mode" probably is only required for 0644 and 0755.
> > 
> > Why should we want to have that patch?  IOW what does it fix, and what 
> > might it break?
> 
> It cleans up the code to make it more readable.
> 
> It makes no sense to be doing S_IFREG | S_IFLINK, which happens when
> the input is for a symlink.  It doesn't break anything to do that |
> operation, but it also looks damn odd when reading the function.

Imagining myself reading the commit message 6 months from now, in all 
likeliness I will have wished that those two paragraphs were in there.  
Verbatim.

Ciao,
Dscho