git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Extend "checkout --track" DWIM to support more cases

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Aug 20, 2008, 19:52 UTC
Message-ID
<alpine.DEB.1.00.0808202151320.24820@pacific.mpi-cbg.de.mpi-cbg.de>
In-Reply-To
<20080820185028.GA16626@blimp.local>
Hi,
On Wed, 20 Aug 2008, Alex Riesen wrote:
Show 26 quoted lines
> The code handles additionally "refs/remotes/<something>/name",
> "remotes/<something>/name", and "refs/<namespace>/name".
> Test cases included.
> 
> Signed-off-by: Alex Riesen <raa.lkml@gmail.com>
> ---
> 
> Johannes has likable ideas :)
> 
>  builtin-checkout.c |   20 +++++++++++++++-----
>  t/t7201-co.sh      |   23 ++++++++++++++++++++++-
>  2 files changed, 37 insertions(+), 6 deletions(-)
> 
> diff --git a/builtin-checkout.c b/builtin-checkout.c
> index e95eab9..20466e2 100644
> --- a/builtin-checkout.c
> +++ b/builtin-checkout.c
> @@ -447,11 +447,21 @@ int cmd_checkout(int argc, const char **argv, const char *prefix)
>  		char *slash;
>  		if (!argc || !strcmp(argv[0], "--"))
>  			die ("--track needs a branch name");
> -		slash = strchr(argv[0], '/');
> -		if (slash && !prefixcmp(argv[0], "refs/"))
> -			slash = strchr(slash + 1, '/');
> -		if (slash && !prefixcmp(argv[0], "remotes/"))
> -			slash = strchr(slash + 1, '/');

Why is this not enough? It strips refs/ if there is one, and remotes/ if there is one (possibly after stripping refs/). No?

Puzzled, Dscho

Previous: Alex RiesenNext: Alex Riesen
Message 2 of 11 in “Extend "checkout --track" DWIM to support more cases”
  1. Extend "checkout --track" DWIM to support more casesAlex Riesen, Aug 20, 2008
  2. Johannes SchindelinAug 20, 2008
  3. Alex RiesenAug 20, 2008
  4. Johannes SchindelinAug 20, 2008
  5. Alex RiesenAug 20, 2008
  6. Junio C HamanoAug 20, 2008
  7. Extend "checkout --track" DWIM to support more casesAlex Riesen, Aug 21, 2008
  8. Junio C HamanoAug 22, 2008
  9. Alex RiesenAug 22, 2008
  10. Junio C HamanoAug 22, 2008
  11. Jay SoffianAug 22, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.