git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Extend "checkout --track" DWIM to support more cases

From
Junio C Hamano <gitster@pobox.com>
Date
Aug 22, 2008, 21:17 UTC
Message-ID
<7v7ia892bp.fsf@gitster.siamese.dyndns.org>
In-Reply-To
<81b0412b0808220208i5de03604rec37081f0bc1cdd4@mail.gmail.com>
"Alex Riesen" <raa.lkml@gmail.com> writes:
Show 12 quoted lines
> 2008/8/22 Junio C Hamano <gitster@pobox.com>:
>> I however wonder if this is clearer.
>
> It is :)
>
>>  * "enum branch_track" was unsigned; comparing equality with -1 was Ok but
>>   we couldn't say 0 < opts.track;
>>
>>  * argv[] is an array of constant strings; cannot point into it with
>>   opts.newbranch without making the latter also a constant string.
>
> Cleanup, but it is unrelated, isn't it?
The code did not compile without it for me as I sometimes use -Werror.
Show 5 quoted lines
>>  * the logic is to strip "refs/" if there is one, "remotes/" if there is
>>   one after that, and then strip one level after that unconditionally.
>>   No need to look explicitly for a slash while doing the first two steps.
>
> Maybe that should go in documentation instead of the piece I wrote

Oh I think what you wrote is fine. I tried to be more descriptive than simply saying "No need to look explicitly for a slash" while explaining the changes.

Previous: Alex RiesenNext: Jay Soffian
Message 10 of 11 in “Extend "checkout --track" DWIM to support more cases”
  1. Extend "checkout --track" DWIM to support more casesAlex Riesen, Aug 20, 2008
  2. Johannes SchindelinAug 20, 2008
  3. Alex RiesenAug 20, 2008
  4. Johannes SchindelinAug 20, 2008
  5. Alex RiesenAug 20, 2008
  6. Junio C HamanoAug 20, 2008
  7. Extend "checkout --track" DWIM to support more casesAlex Riesen, Aug 21, 2008
  8. Junio C HamanoAug 22, 2008
  9. Alex RiesenAug 22, 2008
  10. Junio C HamanoAug 22, 2008
  11. Jay SoffianAug 22, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.