Re: email address handling

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Aug 2, 2008, 11:31 UTC
Message-ID: <alpine.DEB.1.00.0808021321500.9611@pacific.mpi-cbg.de.mpi-cbg.de>
In-Reply-To: <alpine.LFD.1.10.0808011608150.6819@nehalem.linux-foundation.org>

Hi,

On Fri, 1 Aug 2008, Linus Torvalds wrote:

Show 6 quoted lines

> The thing is, you can actually get git to output the crazy names. Just 
> do
> 
> 	git show --pretty=email 37a4c940749670671adab211a2d9c9fed9f3f757
> 
> and now you get the email-prettified thing for at least the author.

Ah, there lies the rub (you forgot that the original complaint was about a comma, and pretty=email does not handle those):

-- snipsnap --

 pretty.c |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/pretty.c b/pretty.c
index 33ef34a..9db0333 100644
--- a/pretty.c
+++ b/pretty.c
@@ -79,7 +79,8 @@ int non_ascii(int ch)
 
 static int is_rfc2047_special(char ch)
 {
-	return (non_ascii(ch) || (ch == '=') || (ch == '?') || (ch == '_'));
+	return (non_ascii(ch) || (ch == '=') || (ch == '?') || (ch == '_') ||
+		(ch == ',') || (ch == '"') || (ch == '\''));
 }
 
 static void add_rfc2047(struct strbuf *sb, const char *line, int len,
@@ -89,7 +90,7 @@ static void add_rfc2047(struct strbuf *sb, const char *line, int len,
 
 	for (i = 0; i < len; i++) {
 		int ch = line[i];
-		if (non_ascii(ch))
+		if (is_rfc2047_special(ch))
 			goto needquote;
 		if ((i + 1 < len) && (ch == '=' && line[i+1] == '?'))
 			goto needquote;