git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: email address handling

From
AMAndrew Morton <akpm@linux-foundation.org>
Date
Aug 1, 2008, 21:58 UTC
Message-ID
<20080801145804.85041bbd.akpm@linux-foundation.org>
In-Reply-To
<7vvdykqub6.fsf@gitster.siamese.dyndns.org>

On Fri, 01 Aug 2008 14:50:05 -0700 Junio C Hamano <gitster@pobox.com> wrote:

Show 17 quoted lines
> Andrew Morton <akpm@linux-foundation.org> writes:
> 
> >> The part _you_ don't seem to understand is that my point is
> >> 
> >>  - git changed that "From:" line to an "Author:" line
> >> 
> >>  - "git log" isn't an email system. It's a human-readable (and 
> >>    machine-parseable, for that matter) log.
> >
> > What you're describing here is some explicit or implicit git design
> > decision and then telling me how it's implemented.
> >
> > Well, what I'm saying is that it was an incorrect design decision.
> 
> What is the objective of your statement in this discussion?  Further add
> fuel to flame, or to seek avenues that lead to some improvement in a
> constructive way?

Well initially it was to work out why the heck my git-log output had stripped the quotes from that person's name, making it unusable for email purposes. I'd actually assumed that it was a bug.

Show 17 quoted lines
> The thing is, I do not think reverting that design decision is an option
> at this point.  People's repositories record <Name, Email> pair already in
> "human readable" form, and people's scripts are assuming that.
> 
> I misspoke about git-send-email earlier; it already has sanitize_address()
> that massages the addresses on From: To: and Cc: lines.  In fact, it even
> seems to have logic to avoid double-quoting, so it would be Ok if you
> changed the design decision this late in the game for that particular
> script, but that does not mean it is a good change --- other scripts
> people may have built around git would need to change.
> 
> So the earlier patch from Dscho (Johannes) may be a step in the right
> direction, but if we are going to rewrite the author information, (1) it
> has to be an option, and (2) when rewriting, it should not be just From:;
> but Signed-off-by:, Cc: and other <Name, Email> pairs at the end of the
> log message would need similar treatment, so that you can cut and paste
> any of them to your MUA.
I preserve the quotes (when present) in signoffs for this exact reason.
Previous: Junio C HamanoNext: Theodore Tso
Message 17 of 41 in “email address handling”
  1. Andrew MortonAug 1, 2008
  2. Linus TorvaldsAug 1, 2008
  3. Andrew MortonAug 1, 2008
  4. Linus TorvaldsAug 1, 2008
  5. Junio C HamanoAug 1, 2008
  6. Andrew MortonAug 1, 2008
  7. Linus TorvaldsAug 1, 2008
  8. Andrew MortonAug 1, 2008
  9. Linus TorvaldsAug 1, 2008
  10. Linus TorvaldsAug 1, 2008
  11. Andrew MortonAug 1, 2008
  12. Linus TorvaldsAug 1, 2008
  13. Johannes SchindelinAug 1, 2008
  14. Junio C HamanoAug 1, 2008
  15. Johannes SchindelinAug 2, 2008
  16. Junio C HamanoAug 1, 2008
  17. Andrew MortonAug 1, 2008
  18. Theodore TsoAug 1, 2008
  19. Andrew MortonAug 1, 2008
  20. Linus TorvaldsAug 1, 2008
  21. Andrew MortonAug 1, 2008
  22. Linus TorvaldsAug 1, 2008
  23. Andrew MortonAug 1, 2008
  24. Linus TorvaldsAug 1, 2008
  25. Karl HasselströmAug 4, 2008
  26. Linus TorvaldsAug 1, 2008
  27. Andrew MortonAug 1, 2008
  28. Linus TorvaldsAug 1, 2008
  29. Linus TorvaldsAug 1, 2008
  30. Johannes SchindelinAug 2, 2008
  31. Linus TorvaldsAug 2, 2008
  32. Junio C HamanoAug 2, 2008
  33. Johannes SchindelinAug 2, 2008
  34. Linus TorvaldsAug 2, 2008
  35. Junio C HamanoAug 2, 2008
  36. Junio C HamanoAug 2, 2008
  37. Junio C HamanoAug 2, 2008
  38. Linus TorvaldsAug 1, 2008
  39. Andrew MortonAug 1, 2008
  40. Junio C HamanoAug 1, 2008
  41. Andrew MortonAug 1, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.